Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cat-voices): Mock data for Discovery Page #1713

Merged
merged 25 commits into from
Jan 30, 2025
Merged

feat(cat-voices): Mock data for Discovery Page #1713

merged 25 commits into from
Jan 30, 2025

Conversation

LynxLynxx
Copy link
Contributor

@LynxLynxx LynxLynxx commented Jan 28, 2025 •
edited
Loading

Description

Creating bloc and mock data for discovery page that handles loading state and error states.

Related Issue(s)

Closes #1552

Description of Changes

Screenshots

If applicable, add screenshots to help explain your changes.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@LynxLynxx LynxLynxx self-assigned this Jan 28, 2025
@LynxLynxx LynxLynxx added the ux/ui UX/UI related issues label Jan 28, 2025
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 445/445}$ | ${\color{red}Fail: 0/445}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 445/445}$ | ${\color{red}Fail: 0/445}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 445/445}$ | ${\color{red}Fail: 0/445}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 445/445}$ | ${\color{red}Fail: 0/445}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 445/445}$ | ${\color{red}Fail: 0/445}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 445/445}$ | ${\color{red}Fail: 0/445}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 445/445}$ | ${\color{red}Fail: 0/445}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 445/445}$ | ${\color{red}Fail: 0/445}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 446/446}$ | ${\color{red}Fail: 0/446}$ |

@LynxLynxx LynxLynxx marked this pull request as ready for review January 29, 2025 11:19
@LynxLynxx LynxLynxx requested a review from dtscalac as a code owner January 29, 2025 11:19
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 447/447}$ | ${\color{red}Fail: 0/447}$ |

damian-molinski

This comment was marked as resolved.

Sign in to view

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 449/449}$ | ${\color{red}Fail: 0/449}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 449/449}$ | ${\color{red}Fail: 0/449}$ |

@damian-molinski damian-molinski added dart Pull requests that update Dart code and removed ux/ui UX/UI related issues labels Jan 30, 2025
LynxLynxx and others added 2 commits January 30, 2025 09:19
@LynxLynxx
feat: add style prop to VoicesOutlinedButton and apply it to hero sec…
613703f 
…tion

* feat: add style prop to VoicesOutlinedButton
  Allows to pass custom style to this button.
* feat: apply VoicesOutlinedButton style to hero section
  Applies `backgroundColor` to myProposals button.
@LynxLynxx
Merge branch 'main' into feat/1552-mock-data
4f4091e
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 449/449}$ | ${\color{red}Fail: 0/449}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 449/449}$ | ${\color{red}Fail: 0/449}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 449/449}$ | ${\color{red}Fail: 0/449}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 449/449}$ | ${\color{red}Fail: 0/449}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 452/452}$ | ${\color{red}Fail: 0/452}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 455/455}$ | ${\color{red}Fail: 0/455}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 455/455}$ | ${\color{red}Fail: 0/455}$ |

damian-molinski
damian-molinski reviewed Jan 30, 2025
View reviewed changes
Copy link
Contributor

@damian-molinski damian-molinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment. Other then that LGTM

catalyst_voices/apps/voices/lib/pages/discovery/sections/most_recent_proposals.dart Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 455/455}$ | ${\color{red}Fail: 0/455}$ |

@LynxLynxx LynxLynxx merged commit 8aa6e1c into main Jan 30, 2025
40 of 42 checks passed
@LynxLynxx LynxLynxx deleted the feat/1552-mock-data branch January 30, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damian-molinski damian-molinski damian-molinski approved these changes

@dtscalac dtscalac Awaiting requested review from dtscalac dtscalac is a code owner

Assignees

@LynxLynxx LynxLynxx

Labels
dart Pull requests that update Dart code
Projects
Catalyst
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Mock Data for Homepage
2 participants
@LynxLynxx @damian-molinski